Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use namespace in controller_manager #435

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

jonatanolofsson
Copy link
Contributor

Add missing namespace parameter to allow controller_manager to be namespaced

Copy link
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes a lot of sense. thanks for the contribution.

@Karsten1987 Karsten1987 merged commit ba77989 into ros-controls:master Jun 7, 2021
@jonatanolofsson
Copy link
Contributor Author

Happy to help!

@jonatanolofsson jonatanolofsson deleted the namespace branch June 7, 2021 20:46
@cco-seasony
Copy link

Hey @jonatanolofsson ,
Thanks for the contribution. I have a question regarding the usage of the namespace. What would be the best way to define the namespace in the controller_manager yaml file?
I have been trying a few things but I do not manage to make it work. Any suggestions are more than welcome.
Thanks in advance!

@jonatanolofsson
Copy link
Contributor Author

@cco-seasony Namespaces should be defined in your launch-file, as the structure of your configuration-file depends on the namespace your node is in.

@cco-seasony
Copy link

cco-seasony commented Jun 14, 2021

@jonatanolofsson Thanks for your reply. The issue is that I am using the gazebo_ros2_control plugin where the config file is parsed in the urdf-file of the robot as a parameter. I already have everything set up with my desired namespace in the launch files but I cannot manage to give a namespace to the controller_manager when using it in the gazebo_ros2 _control plugin.

@jonatanolofsson
Copy link
Contributor Author

@cco-seasony For the case of gazebo_ros2_control, you may be interested in my PR: ros-controls/gazebo_ros2_control#80

@cco-seasony
Copy link

@jonatanolofsson amazing, that is exactly what I needed. Thanks! I will follow the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants