rename get_current_state() to get_state() #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmagyar
force-pushed
the
rename-stuff
branch
from
1536cd0
to
6e3fb42
Compare
|
This PR already had one approval here: #508 |
bmagyar
approved these changes
Sep 5, 2021
8 tasks
zultron
added a commit
to zultron/hal_ros_control
that referenced
this pull request
Apr 10, 2023
`controller_manager::ControllerManager` `get_current_state()` member function renamed to `get_state()` ros-controls/ros2_control#512 [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp: In function ‘void reset_controller_cb()’: [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp:93:23: error: ‘using element_type = class controller_interface::ControllerInterfaceBase’ {aka ‘class controller_interface::ControllerInterfaceBase’} has no member named ‘get_current_state’ 93 | if (controller.c->get_current_state().id() == | ^~~~~~~~~~~~~~~~~ `rclcpp::InitOptions`: `shutdown_on_siginc` member variable renamed to `shutdown_on_signal` ros2/rclcpp#1771 [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp: In function ‘int rtapi_app_main()’: [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp:136:13: error: ‘class rclcpp::InitOptions’ has no member named ‘shutdown_on_sigint’; did you mean ‘shutdown_on_signal’? 136 | init_opts.shutdown_on_sigint = false; | ^~~~~~~~~~~~~~~~~~ | shutdown_on_signal `controller_manager::ControllerManager`: `read()`/`update()`/`write()` member function signatures changed to require time and period args ros-controls/ros2_control#715 [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp: In function ‘void funct(void*, int64_t)’: [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp:230:55: error: cannot convert ‘int64_t’ {aka ‘long int’} to ‘const rclcpp::Duration&’ 230 | CONTROLLER_MANAGER->read(CONTROLLER_MANAGER->now(), period); | ^~~~~~ | | | int64_t {aka long int} In file included from [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp:37: /opt/ros/humble/include/controller_manager/controller_manager.hpp:155:65: note: initializing argument 2 of ‘void controller_manager::ControllerManager::read(const rclcpp::Time&, const rclcpp::Duration&)’ 155 | void read(const rclcpp::Time & time, const rclcpp::Duration & period); | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp:235:57: error: cannot convert ‘int64_t’ {aka ‘long int’} to ‘const rclcpp::Duration&’ 235 | CONTROLLER_MANAGER->update(CONTROLLER_MANAGER->now(), period); | ^~~~~~ | | | int64_t {aka long int} In file included from [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp:37: /opt/ros/humble/include/controller_manager/controller_manager.hpp:167:57: note: initializing argument 2 of ‘controller_interface::return_type controller_manager::ControllerManager::update(const rclcpp::Time&, const rclcpp::Duration&)’ 167 | const rclcpp::Time & time, const rclcpp::Duration & period); | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp:241:56: error: cannot convert ‘int64_t’ {aka ‘long int’} to ‘const rclcpp::Duration&’ 241 | CONTROLLER_MANAGER->write(CONTROLLER_MANAGER->now(), period); | ^~~~~~ | | | int64_t {aka long int} In file included from [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp:37: /opt/ros/humble/include/controller_manager/controller_manager.hpp:178:66: note: initializing argument 2 of ‘void controller_manager::ControllerManager::write(const rclcpp::Time&, const rclcpp::Duration&)’ 178 | void write(const rclcpp::Time & time, const rclcpp::Duration & period); | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
zultron
added a commit
to zultron/hal_ros_control
that referenced
this pull request
Apr 14, 2023
`controller_manager::ControllerManager` `get_current_state()` member function renamed to `get_state()` ros-controls/ros2_control#512 [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp: In function ‘void reset_controller_cb()’: [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp:93:23: error: ‘using element_type = class controller_interface::ControllerInterfaceBase’ {aka ‘class controller_interface::ControllerInterfaceBase’} has no member named ‘get_current_state’ 93 | if (controller.c->get_current_state().id() == | ^~~~~~~~~~~~~~~~~ `rclcpp::InitOptions`: `shutdown_on_siginc` member variable renamed to `shutdown_on_signal` ros2/rclcpp#1771 [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp: In function ‘int rtapi_app_main()’: [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp:136:13: error: ‘class rclcpp::InitOptions’ has no member named ‘shutdown_on_sigint’; did you mean ‘shutdown_on_signal’? 136 | init_opts.shutdown_on_sigint = false; | ^~~~~~~~~~~~~~~~~~ | shutdown_on_signal `controller_manager::ControllerManager`: `read()`/`update()`/`write()` member function signatures changed to require time and period args ros-controls/ros2_control#715 [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp: In function ‘void funct(void*, int64_t)’: [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp:230:55: error: cannot convert ‘int64_t’ {aka ‘long int’} to ‘const rclcpp::Duration&’ 230 | CONTROLLER_MANAGER->read(CONTROLLER_MANAGER->now(), period); | ^~~~~~ | | | int64_t {aka long int} In file included from [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp:37: /opt/ros/humble/include/controller_manager/controller_manager.hpp:155:65: note: initializing argument 2 of ‘void controller_manager::ControllerManager::read(const rclcpp::Time&, const rclcpp::Duration&)’ 155 | void read(const rclcpp::Time & time, const rclcpp::Duration & period); | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp:235:57: error: cannot convert ‘int64_t’ {aka ‘long int’} to ‘const rclcpp::Duration&’ 235 | CONTROLLER_MANAGER->update(CONTROLLER_MANAGER->now(), period); | ^~~~~~ | | | int64_t {aka long int} In file included from [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp:37: /opt/ros/humble/include/controller_manager/controller_manager.hpp:167:57: note: initializing argument 2 of ‘controller_interface::return_type controller_manager::ControllerManager::update(const rclcpp::Time&, const rclcpp::Duration&)’ 167 | const rclcpp::Time & time, const rclcpp::Duration & period); | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp:241:56: error: cannot convert ‘int64_t’ {aka ‘long int’} to ‘const rclcpp::Duration&’ 241 | CONTROLLER_MANAGER->write(CONTROLLER_MANAGER->now(), period); | ^~~~~~ | | | int64_t {aka long int} In file included from [...]/hal_ros_control/hal_hw_interface/src/hal_control_node.cpp:37: /opt/ros/humble/include/controller_manager/controller_manager.hpp:178:66: note: initializing argument 2 of ‘void controller_manager::ControllerManager::write(const rclcpp::Time&, const rclcpp::Duration&)’ 178 | void write(const rclcpp::Time & time, const rclcpp::Duration & period); | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.