Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller_manager: Use command_interface_configuration for the claimed interfaces when calling list_controllers #544

Merged
merged 8 commits into from Oct 15, 2021
Merged

controller_manager: Use command_interface_configuration for the claimed interfaces when calling list_controllers #544

merged 8 commits into from Oct 15, 2021

Conversation

JafarAbdi
Copy link
Contributor

Fix: #464

destogl
destogl reviewed Sep 29, 2021
View reviewed changes
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will optimize this a bit in the next few days. This is not 💯% correct now.

destogl
destogl requested changes Sep 29, 2021
View reviewed changes
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment below, it would be needed to extend ros2controlcli for parsing new proposed fields.

Thanks for contribution!

controller_manager/src/controller_manager.cpp Outdated Show resolved Hide resolved
controller_manager/test/test_controller_manager_srvs.cpp Outdated Show resolved Hide resolved
@schornakj schornakj mentioned this pull request Oct 8, 2021
Closed
6 tasks
destogl
destogl approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now! Thanks!

ros2controlcli/ros2controlcli/verb/list_controllers.py Outdated Show resolved Hide resolved
@bmagyar bmagyar merged commit 18fe5ea into ros-controls:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@destogl destogl destogl approved these changes

@bmagyar bmagyar bmagyar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

controller manager doesn't return the controller's joints when it's inactive
3 participants
@JafarAbdi @destogl @bmagyar