-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualize chained controllers with graphviz #763
Visualize chained controllers with graphviz #763
Conversation
Codecov Report
@@ Coverage Diff @@
## master #763 +/- ##
==========================================
- Coverage 34.61% 32.69% -1.93%
==========================================
Files 52 90 +38
Lines 2981 8620 +5639
Branches 1855 5765 +3910
==========================================
+ Hits 1032 2818 +1786
- Misses 310 673 +363
- Partials 1639 5129 +3490
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This looks very cool! What do you think that we create a rqt plugin for that? |
I was taking inspiration from |
That is a very cool feature indeed. |
What if I make the lines dashed if the interface is not claimed and solid if it is? And what if I put the controller status (active, inactive) underneath the name at the top of each node? |
Agreed for the dashed lines. |
…into pr-add-chained-controllers-in-srv-cb � Conflicts: � controller_manager/test/test_controller_manager_srvs.cpp
…48/ros2_control into pr-visualize-chained-controllers
This pull request is in conflict. Could you fix it @pac48? |
…into pr-visualize-chained-controllers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor cleanup
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
…into pr-visualize-chained-controllers
…os2_control into pr-visualize-chained-controllers
This change depends on this PR. It adds a new command line option
ros2 control view_controller_chains
, which generates an image using Graphviz.