Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller Manager should not crash when trying to start finalized or unconfigured controller #461

Merged

Conversation

destogl
Copy link
Member

@destogl destogl commented Jul 13, 2021

  • Avoid crashing of controller manager when trying to start a controller in finalized or unconfigured state.

@destogl destogl added the bug label Jul 13, 2021
@destogl destogl self-assigned this Jul 13, 2021
@destogl
Copy link
Member Author

destogl commented Jul 13, 2021

I need some help with tests. I am not really sure why they are failing.

@destogl destogl requested a review from v-lopez July 13, 2021 15:26
@destogl destogl changed the title Controller Manager should not crash when trying to start finalized and unconfigured controller Controller Manager should not crash when trying to start finalized or unconfigured controller Jul 13, 2021
@bmagyar bmagyar self-requested a review July 23, 2021 07:24
@destogl destogl force-pushed the cm-crash-on-finalized-controller branch from 370d65d to dc227bc Compare September 6, 2021 16:00
@destogl destogl force-pushed the cm-crash-on-finalized-controller branch from dc227bc to d422f7c Compare September 6, 2021 16:03
@destogl
Copy link
Member Author

destogl commented Sep 7, 2021

We should also add tests for BEST_EFFORT controller switching in CM.

@destogl destogl merged commit 85f21c2 into ros-controls:master Sep 7, 2021
@destogl destogl deleted the cm-crash-on-finalized-controller branch September 7, 2021 06:50
@bmagyar
Copy link
Member

bmagyar commented Sep 7, 2021

@Mergifyio backport foxy

@mergify
Copy link
Contributor

mergify bot commented Sep 7, 2021

Command backport foxy: failure

No backport have been created

  • Backport to branch foxy failed: Git reported the following error:
Auto-merging controller_manager/test/test_load_controller.cpp
CONFLICT (content): Merge conflict in controller_manager/test/test_load_controller.cpp
Auto-merging controller_manager/src/controller_manager.cpp
error: could not apply 85f21c2... Controller Manager should not crash when trying to start finalized or unconfigured controller (#461)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

destogl added a commit to destogl/ros2_control that referenced this pull request Sep 7, 2021
bmagyar pushed a commit that referenced this pull request Sep 7, 2021
pac48 pushed a commit to pac48/ros2_control that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants