-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagnostics #820
Add diagnostics #820
Conversation
tonynajjar
commented
Sep 26, 2022
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds pretty neat to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great feature!
I propose different names of the callback method to make it clear what it is. What do you think?
controller_manager/include/controller_manager/controller_manager.hpp
Outdated
Show resolved
Hide resolved
@destogl your proposals make sense, will apply them |
Sorry for killing formatting... |
No problem I was already fighting with it anyway 😅. I think it should be fine now |
I don't know if you have flaky tests, let me know if there is something more to fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@megifyio backport humble |
@destogl looks like you have a typo |
Also don't forget to backport #836 with it! |
Can you guys fill me in on what this changes? Previously, the controllers would publish a |
@destogl this was never executed, could we backport this? |
Kind reminder, we would like to not have to clone this repo anymore on Humble for this feature |
Sorry guys |
@Mergifyio backport to humble |
(cherry picked from commit b1f31a1) # Conflicts: # controller_manager/src/controller_manager.cpp
✅ Backports have been created
|
This reverts commit dca10f4. Signed-off-by: Joe Schornak <joe.schornak@gmail.com>
This reverts commit dca10f4. Signed-off-by: Joe Schornak <joe.schornak@gmail.com>