Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admittance Controller Demo #140

Closed

Conversation

destogl
Copy link
Member

@destogl destogl commented Oct 21, 2021

Please check using_admittance_controller.md for instructions.

@destogl destogl changed the title Add repos file for admittance controller Add Admittance Controller Demo Oct 21, 2021
@destogl destogl changed the title Add Admittance Controller Demo Admittance Controller Demo Oct 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #140 (658ff0c) into master (93aec17) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #140     +/-   ##
========================================
  Coverage    0.00%   0.00%             
========================================
  Files          88       4     -84     
  Lines        8382     381   -8001     
========================================
+ Misses       8382     381   -8001     
Flag Coverage Δ
unittests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...demo_hardware/src/rrbot_system_multi_interface.cpp
...rol_demo_hardware/src/rrbot_system_with_sensor.cpp
...demo_hardware/src/rrbot_system_multi_interface.cpp
.../ros2_control_demo_hardware/src/diffbot_system.cpp
...l_demo_hardware/src/rrbot_system_position_only.cpp
...demo_hardware/src/rrbot_system_multi_interface.cpp
...demo_hardware/src/rrbot_system_multi_interface.cpp
.../ros2_control_demo_hardware/src/diffbot_system.cpp
...demo_hardware/src/rrbot_system_multi_interface.cpp
...l_demo_hardware/src/rrbot_system_position_only.cpp
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93aec17...658ff0c. Read the comment docs.

Universal_Robots_ROS2_Driver: # Branch: main
type: git
url: https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver.git
version: f0fc36c04065f609cec5b99c3cc88c363d25fd41 # Correct format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs updating. I don't think this commit hash exists

AndyZe
AndyZe previously approved these changes Oct 26, 2021
Copy link
Contributor

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested this -- it works well 👍

@@ -0,0 +1,54 @@
# joint_limits.yaml allows the dynamics properties specified in the URDF to be overwritten or augmented as needed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to delete these rrbot files since the demo uses the UR robot.

```


## Test with URSim (not finished!)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would suggest simply to delete this section. The generic simulated controller works quite well.


IK:
base: base_link # Assumed to be stationary
tip: tool0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this parameter is unused. Delete it?

IK:
base: base_link # Assumed to be stationary
tip: tool0
group_name: ur5e_manipulator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If/when you merge my plugin PR, you'll need to add this parameter here:

plugin_name: moveit_differential_ik_plugin::MoveItKinematics

iirob_filters: # Branch: ros2
type: git
url: https://github.com/nbbrooks/iirob_filters.git
version: d0c9a21672264ae9506686de9ff928e6ada96f15 # Changes for Galactic/Rolling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If/when you merge my plugin PR, you'll have to add the plugin repository here:

https://github.com/PickNikRobotics/moveit_differential_ik_plugin.git

@christophfroehlich
Copy link
Contributor

Closing this one in favor of #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New example This PR is proposing a new example.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants