Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue : 114 #259

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Conversation

bailaC
Copy link
Contributor

@bailaC bailaC commented Oct 18, 2021

This PR will fix #114

@bailaC
Copy link
Contributor Author

bailaC commented Oct 18, 2021

@destogl , @bmagyar please have a look.

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

@destogl destogl self-requested a review October 19, 2021 12:48
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@bmagyar bmagyar merged commit 0e2a43a into ros-controls:master Oct 25, 2021
@destogl destogl deleted the 114_issue branch October 25, 2021 07:14
gwalck pushed a commit to StoglRobotics-forks/ros2_controllers that referenced this pull request Jun 7, 2023
* Remove unused ActuatorHandle from hardware_interface

* Remove unused control_type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move interface sorting into ControllerInterface
3 participants