Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TricycleController] Fix deprecation warnings when compiling #478

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

destogl
Copy link
Member

@destogl destogl commented Dec 3, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #478 (786b580) into master (e7f9962) will decrease coverage by 6.07%.
The diff coverage is 20.15%.

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
- Coverage   35.78%   29.70%   -6.08%     
==========================================
  Files         189        7     -182     
  Lines       17570      744   -16826     
  Branches    11592      429   -11163     
==========================================
- Hits         6287      221    -6066     
+ Misses        994      163     -831     
+ Partials    10289      360    -9929     
Flag Coverage Δ
unittests 29.70% <20.15%> (-6.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...ontroller/test/test_load_diff_drive_controller.cpp 12.50% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <13.33%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 20.00% <20.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 32.04% <24.01%> (ø)
...test/test_load_joint_group_velocity_controller.cpp
...ory_controller/src/joint_trajectory_controller.cpp
...ontrollers/src/joint_group_velocity_controller.cpp
... and 192 more

@bmagyar bmagyar merged commit 4b9c06a into master Dec 6, 2022
@bmagyar bmagyar deleted the fixup-deprecation-tricycle-ctrl branch December 6, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants