-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing to_chrono to use nanoseconds #507
Conversation
Previously std::chrono::seconds, which rounds to 0 if action_monitor_period_ < 1
A related bugfix with JTC also resets the timer pointer so you don't end up creating multiple ones. We should do the same here - it's a shame noone caught the pattern being used here in gripper controller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix!
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #507 +/- ##
==========================================
- Coverage 35.78% 32.48% -3.31%
==========================================
Files 189 7 -182
Lines 17570 665 -16905
Branches 11592 357 -11235
==========================================
- Hits 6287 216 -6071
+ Misses 994 157 -837
+ Partials 10289 292 -9997
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thanks for the follow-up!
@Mergifyio backport to humble |
* Changing to_chrono to use nanoseconds Previously std::chrono::seconds, which rounds to 0 if action_monitor_period_ < 1 * Reset gripper action goal timer to match JTC impl (cherry picked from commit ec80aba)
✅ Backports have been created
|
Previously std::chrono::seconds, which rounds to 0 if action_monitor_period_ < 1