Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github links on control.ros.org #604

Merged
merged 3 commits into from
May 14, 2023

Conversation

christophfroehlich
Copy link
Contributor

This is a companion PR to ros-controls/control.ros.org#85. More details can be found there.

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New files without this or ill-defined paths still won't break the page, but only the URL, right?

@christophfroehlich
Copy link
Contributor Author

Exactly, if github_url is not set it uses the autogenerated one for the link

https://github.com/readthedocs/sphinx_rtd_theme/blob/03a86b803cf7cf281748ef94345ba7c35953952a/sphinx_rtd_theme/breadcrumbs.html#L35-L40

@codecov-commenter
Copy link

Codecov Report

Merging #604 (3e59d8e) into master (e7f9962) will increase coverage by 0.20%.
The diff coverage is 33.82%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
+ Coverage   35.78%   35.98%   +0.20%     
==========================================
  Files         189        7     -182     
  Lines       17570      678   -16892     
  Branches    11592      362   -11230     
==========================================
- Hits         6287      244    -6043     
+ Misses        994      134     -860     
+ Partials    10289      300    -9989     
Flag Coverage Δ
unittests 35.98% <33.82%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontroller/test/test_load_diff_drive_controller.cpp 11.11% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 45.76% <45.02%> (ø)
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <100.00%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 100.00% <100.00%> (ø)

... and 189 files with indirect coverage changes

@bmagyar bmagyar merged commit 334e4f2 into ros-controls:master May 14, 2023
10 of 12 checks passed
@christophfroehlich christophfroehlich deleted the fix_github_links branch May 15, 2023 06:31
@christophfroehlich
Copy link
Contributor Author

@bmagyar pls backport to humble, too

@bmagyar
Copy link
Member

bmagyar commented May 16, 2023

https://github.com/Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented May 16, 2023

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 16, 2023
* Fix github links

* Add local github_url for sphinx

(cherry picked from commit 334e4f2)
bmagyar pushed a commit that referenced this pull request May 16, 2023
* Fix github links

* Add local github_url for sphinx

(cherry picked from commit 334e4f2)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants