-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command final waypoint identically when traj_point_active_ptr_ is null #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anfemosa,
arne48,
bmagyar,
destogl,
jackcenter,
jaron-l and
LukasMacha97
June 22, 2023 21:40
destogl
added
the
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
label
Jun 26, 2023
bmagyar
approved these changes
Jun 26, 2023
destogl
approved these changes
Jun 26, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #682 +/- ##
==========================================
+ Coverage 35.78% 36.53% +0.75%
==========================================
Files 189 7 -182
Lines 17570 676 -16894
Branches 11592 357 -11235
==========================================
- Hits 6287 247 -6040
+ Misses 994 134 -860
+ Partials 10289 295 -9994
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Jun 27, 2023
…ve_ptr_ is nullptr (ros-controls#682)" This reverts commit 9ce288b.
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Jun 29, 2023
…ve_ptr_ is nullptr (ros-controls#682)" This reverts commit 9ce288b.
mechwiz
pushed a commit
to mechwiz/ros2_controllers
that referenced
this pull request
Jul 3, 2023
…ve_ptr_ is nullptr (ros-controls#682)" This reverts commit 9ce288b.
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Jul 17, 2023
…ve_ptr_ is nullptr (ros-controls#682)" This reverts commit 9ce288b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #671
Redux of #672 fix sent directly to master.
Requesting a back-port to
humble
if possible, as this seems to fix a bug noticed by anybody using closed-loop velocity or effort hardware control.Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:
colcon test
andpre-commit run
(requires you to install pre-commit bypip3 install pre-commit
)