Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command final waypoint identically when traj_point_active_ptr_ is null #682

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

egordon
Copy link
Contributor

@egordon egordon commented Jun 22, 2023

Addresses #671

Redux of #672 fix sent directly to master.
Requesting a back-port to humble if possible, as this seems to fix a bug noticed by anybody using closed-loop velocity or effort hardware control.

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

@destogl destogl added the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Jun 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #682 (6919f38) into master (e7f9962) will increase coverage by 0.75%.
The diff coverage is 34.91%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
+ Coverage   35.78%   36.53%   +0.75%     
==========================================
  Files         189        7     -182     
  Lines       17570      676   -16894     
  Branches    11592      357   -11235     
==========================================
- Hits         6287      247    -6040     
+ Misses        994      134     -860     
+ Partials    10289      295    -9994     
Flag Coverage Δ
unittests 36.53% <34.91%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontroller/test/test_load_diff_drive_controller.cpp 11.11% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 47.09% <46.88%> (ø)
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <100.00%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 100.00% <100.00%> (ø)

... and 189 files with indirect coverage changes

@destogl destogl merged commit 9ce288b into ros-controls:master Jun 26, 2023
13 checks passed
mergify bot pushed a commit that referenced this pull request Jun 26, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Jun 27, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Jun 29, 2023
bmagyar pushed a commit that referenced this pull request Jul 2, 2023
mechwiz pushed a commit to mechwiz/ros2_controllers that referenced this pull request Jul 3, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Jul 17, 2023
bmagyar pushed a commit that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants