Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Specify runner/container images #1105

Merged
merged 1 commit into from
Apr 29, 2024
Merged

[CI] Specify runner/container images #1105

merged 1 commit into from
Apr 29, 2024

Conversation

christophfroehlich
Copy link
Contributor

Necessary changes to make ros-controls/ros2_control_ci#53 work for noble.

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Apr 24, 2024
fmauch
fmauch approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing CI seems unrelated?

@christophfroehlich
Copy link
Contributor Author

Failing CI seems unrelated?

mostly #1101

@christophfroehlich christophfroehlich merged commit 2a59f60 into master Apr 29, 2024
5 of 12 checks passed
@christophfroehlich christophfroehlich deleted the ci_noble branch April 29, 2024 19:09
mergify bot pushed a commit that referenced this pull request Apr 29, 2024
@christophfroehlich @mergify
[CI] Specify runner/container images (#1105)
9f56add 
(cherry picked from commit 2a59f60)
@mergify mergify bot mentioned this pull request Apr 29, 2024
Merged
mergify bot pushed a commit that referenced this pull request Apr 29, 2024
@christophfroehlich @mergify
[CI] Specify runner/container images (#1105)
838f02c 
(cherry picked from commit 2a59f60)
@mergify mergify bot mentioned this pull request Apr 29, 2024
Merged
christophfroehlich added a commit that referenced this pull request Apr 29, 2024
@mergify @christophfroehlich
[CI] Specify runner/container images (#1105) (#1112)
54bb1e1 
(cherry picked from commit 2a59f60)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich added a commit that referenced this pull request Apr 29, 2024
@mergify @christophfroehlich
[CI] Specify runner/container images (#1105) (#1113)
93a7275 
(cherry picked from commit 2a59f60)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
@saikishor
Proper controller update rate (ros-controls#1105)
28711db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivier-stasse olivier-stasse olivier-stasse approved these changes

@fmauch fmauch fmauch approved these changes

@saikishor saikishor saikishor approved these changes

@arne48 arne48 Awaiting requested review from arne48

@bmagyar bmagyar Awaiting requested review from bmagyar

@destogl destogl Awaiting requested review from destogl

@erickisos erickisos Awaiting requested review from erickisos

@VanshGehlot VanshGehlot Awaiting requested review from VanshGehlot

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@christophfroehlich @olivier-stasse @fmauch @saikishor