-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STEERING] Add missing tan
call for ackermann
#1117
[STEERING] Add missing tan
call for ackermann
#1117
Conversation
@saikishor FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qinqon It would be great if you can also update the docs with some references to the actual math, so we can avoid this in future.
Will you be able to add some tests?
Do you know if the original author added some reference somewhere ?
Yep, will do that too. |
Regarding docs: No, the original author did not include any. Please have a look at #954 and review what I've written there. |
Ahh that's much needed, thanks. @christophfroehlich someting a little off topic, I am preparing a PR to implement swerve drive re-using/refactoring steering library, does it make sense, or is better to create a new controller ? |
Please open a separate issue and propose your changes. I also had a rewrite of the steering library in mind, maybe we can find a proper way going forward. We can also discuss this on slack, I can add ellorent@redhat.com if you want? |
Can you add me with my personal email ? quique.llorente@gmail.com |
@qinqon this is still missing? |
This pull request is in conflict. Could you fix it @qinqon? |
24b033f
to
b505bc6
Compare
Signed-off-by: Quique Llorente <ellorent@redhat.com>
Signed-off-by: Quique Llorente <ellorent@redhat.com>
8b5497a
to
daba669
Compare
(cherry picked from commit b81be48)
(cherry picked from commit b81be48)
(cherry picked from commit b81be48) Co-authored-by: Enrique Llorente Pastora <ellorent@redhat.com>
(cherry picked from commit b81be48) Co-authored-by: Enrique Llorente Pastora <ellorent@redhat.com>
The steering library is missing a call to calculate tangent from steering pos at ackermann code.