Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from dash to underscore in setup.cfg #595

Merged

Conversation

moriarty
Copy link
Contributor

@moriarty moriarty commented May 4, 2023

This fixes the warning which was introduced here:
pypa/setuptools@a2e9ae4cb

This fixes the warning which was introduced here:
pypa/setuptools@a2e9ae4cb

Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and also the reference!

@codecov-commenter
Copy link

Codecov Report

Merging #595 (43c773e) into master (e7f9962) will increase coverage by 0.02%.
The diff coverage is 33.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
+ Coverage   35.78%   35.80%   +0.02%     
==========================================
  Files         189        7     -182     
  Lines       17570      673   -16897     
  Branches    11592      361   -11231     
==========================================
- Hits         6287      241    -6046     
+ Misses        994      132     -862     
+ Partials    10289      300    -9989     
Flag Coverage Δ
unittests 35.80% <33.13%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontroller/test/test_load_diff_drive_controller.cpp 11.11% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 45.51% <44.17%> (ø)
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <100.00%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 100.00% <100.00%> (ø)

... and 189 files with indirect coverage changes

@bmagyar bmagyar merged commit 546422d into ros-controls:master May 7, 2023
11 of 13 checks passed
@bmagyar
Copy link
Member

bmagyar commented May 8, 2023

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented May 8, 2023

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 8, 2023
This fixes the warning which was introduced here:
pypa/setuptools@a2e9ae4cb

Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
(cherry picked from commit 546422d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants