[tricycle_controller] Use generate_parameter_library #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
backport-humble
github-actions
bot
requested review from
bmagyar,
DasRoteSkelett,
destogl,
duringhof,
erickisos,
jaron-l and
saikishor
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #957 +/- ##
==========================================
+ Coverage 47.81% 48.47% +0.66%
==========================================
Files 41 41
Lines 3871 3812 -59
Branches 1827 1771 -56
==========================================
- Hits 1851 1848 -3
+ Misses 751 749 -2
+ Partials 1269 1215 -54
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
reviewed
Jan 11, 2024
| @@ -357,7 +291,7 @@ CallbackReturn TricycleController::on_configure(const rclcpp_lifecycle::State & | |||
| } | |||
|
|
|||
| // initialize command subscriber | |||
| if (use_stamped_vel_) | |||
| if (params_.use_stamped_vel) | |||
There was a problem hiding this comment.
probably due to be removed soon too
There was a problem hiding this comment.
in this PR or in a follow up?
bmagyar
reviewed
Jan 11, 2024
christophfroehlich
force-pushed
the
tricycle_touchups
branch
from
054e008
to
88b6c12
Compare
bmagyar
approved these changes
Jan 29, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
(cherry picked from commit 8d732f1) # Conflicts: # tricycle_controller/src/tricycle_controller.cpp # tricycle_controller/test/test_tricycle_controller.cpp
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
(cherry picked from commit 8d732f1) # Conflicts: # tricycle_controller/test/test_tricycle_controller.cpp
christophfroehlich
added a commit
that referenced
this pull request
Mar 13, 2024
(cherry picked from commit 8d732f1) # Conflicts: # tricycle_controller/src/tricycle_controller.cpp # tricycle_controller/test/test_tricycle_controller.cpp
christophfroehlich
added a commit
that referenced
this pull request
Mar 13, 2024
(cherry picked from commit 8d732f1) # Conflicts: # tricycle_controller/test/test_tricycle_controller.cpp
bmagyar
pushed a commit
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title.
I also updated the documentation a bit, see #850
This breaks ABI because of the class variable change, is this a bad idea to backport?