Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/velocity_controllers/joint_position_controller rebased to indigo-devel #117

Conversation

fmessmer
Copy link
Contributor

This is a rebase of #108

@fmessmer
Copy link
Contributor Author

Is it possible to merge this PR?
Or is there any issue left that needs to be fixed?

@adolfo-rt
Copy link
Member

Coming back to the open question from #108 (here). What kind of testing or validation has this controller seen?. Given that there is no test suite, I'd at least like confirmation that under some conditions the controller behaves as expected.

@fmessmer
Copy link
Contributor Author

fmessmer commented Sep 3, 2014

We have been usíng this together with simulation (Gazebo) and a (very simple 1DoF) hardware.
The controller appears to do what it is promising: position control for velocity interfaces...

@adolfo-rt
Copy link
Member

Thanks for the confirmation.

Please remove the first commit, as it's a patch that affects hydro only, and is orthogonal to this PR.

@fmessmer fmessmer force-pushed the feature/velocity_controllers/JointPositionController_indigo branch from 86c1707 to 3c73ae3 Compare September 4, 2014 07:53
@fmessmer
Copy link
Contributor Author

fmessmer commented Sep 4, 2014

I cleaned up this PR so that in only consists of the relevant commit. This should be it!

@adolfo-rt
Copy link
Member

+1

adolfo-rt pushed a commit that referenced this pull request Sep 4, 2014
…ntPositionController_indigo

feature/velocity_controllers/joint_position_controller rebased to indigo-devel
@adolfo-rt adolfo-rt merged commit 84b55e9 into ros-controls:indigo-devel Sep 4, 2014
@fmessmer fmessmer deleted the feature/velocity_controllers/JointPositionController_indigo branch September 4, 2014 15:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants