Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compile error caused by missing include #197

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

Kurtoid
Copy link

@Kurtoid Kurtoid commented Feb 12, 2021

stat_vector_3d.cpp uses std::runtime_error, which is included in stdexcept

I couldn't build joystick_drivers without it

`stat_vector_3d.cpp` uses `std::runtime_error`, which is included in `stdexcept`

I couldn't build joystick_drivers without it
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the sentiment of include-what-you-use, but since it is only required in stat_vector_3d.cpp, let's put the include there.

@clalancette
Copy link
Contributor

Looks good to me! Rpr job is failing for completely unrelated reasons (PR coming soon). Thanks for the contribution, merging.

@clalancette clalancette merged commit d8d8b02 into ros-drivers:ros2 Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants