Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for Noetic #98

Merged
merged 4 commits into from
Jun 3, 2020
Merged

Release for Noetic #98

merged 4 commits into from
Jun 3, 2020

Conversation

130s
Copy link
Member

@130s 130s commented Jun 3, 2020

Changes made

Branch

  • Based off of indigo-devel (which is used for up to ROS Melodic release)
  • Target: noetic-devel (which I just branched off of indigo-devel).

CoS

  • CI cnofig update. CI should pass.

@130s
Copy link
Member Author

130s commented Jun 3, 2020

Travis CI job for noetic fails https://travis-ci.org/github/ros-drivers/openni2_camera/jobs/694065338#L439 looking for a released .deb of rgbd_launch

@mikeferguson
Copy link
Member

looks like you also merged my noetic fixes into indigo-devel, but not noetic-devel branch

@130s 130s changed the title WIP: Release for Noetic Release for Noetic Jun 3, 2020
@130s
Copy link
Member Author

130s commented Jun 3, 2020

With a recent issue with the released version of catkin_tools catkin/catkin_tools#594 (comment), all CI jobs on travis failed.

I go ahead and make a release to rosdistro. Because there's already a hold discourse.ros.org#14451, release may get stuck though.

@130s 130s merged commit 6736cd2 into noetic-devel Jun 3, 2020
@130s 130s deleted the release-noetic branch June 3, 2020 22:37
@130s
Copy link
Member Author

130s commented Jun 3, 2020

looks like you also merged my noetic fixes into indigo-devel, but not noetic-devel branch

Thanks for the headup. My understanding, can be wrong though, is that the changes added in #97, which is package format 3 change, work even on indigo as format 3 support is done in catkin_pkg, which is agnostic to distro of OS and ROS.

I leave it as is on both indigo branch (used for indigo before noetic) and noetic branch for now unless there's an issue with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants