-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/time #497
Fix/time #497
Conversation
Ok, I was hoping Travis has a different workspace setup than I do, but I get the same redefinition error of Can someone help me? How do I #include "ros_lib/ros/duration.h" in the unit test without redefining
|
You figured out one way. Another is to wrap the include in a namespace to isolate it from its surroundings; we do this for the |
In #169 @PaulBouchier mentions that the implementation of subtraction and addition of time and duration may be erroneous. We actually observed that
indeed lead to a wrong result on our system.
This PR implements the fix provided by @chuck-h and additional unit tests.
Since I cannot run the unit tests on my machine I'm creating this draft PR first.