migrate ros2 devel #11
Conversation
Initial port of the urg_c package to ros 2
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
@Karsten1987 the default ros2 linters sound good to me. |
|
I tried to enable the default linters (cpplint, uncrustify, etc.) but given the amount of utf-8 character and such applying the linters is basically impossible. |
The CMake target was named "liburg_c", which means that the final library was "libliburg_c", which is just weird. Rename the target to urg_c, and also mark it as SHARED so it works when building as a component. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Rename the urg_c library and make it shared.
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
This reverts commit 83e68fb.
|
had to remove the static cast as it's a C-only library. |
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Oh, haha, my bad. I didn't realize that. Looks good 👍 |
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Karsten1987
force-pushed
the
ros2-devel
branch
from
1f2e0ea
to
bf2ef73
Compare
|
@chadrockey @tonybaltovski This looks good to me now, and is passing CI. I think this is ready to merge. Please give it a look and let us know of any comments you have. If I don't hear anything by the end of the week, I'll go ahead and merge and we can follow-up later. |
|
I'm going to go ahead and merge this, but as always, feel free to leave comments and we can follow-up later. |
This is a first PR to import the work done by @bponsler and @MarcTestier.
I am trying to be non-intrusive in terms of style, but I am happy to run the batch of default ros2 linters. I leave that decision though to @tonybaltovski.