Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS2: Add Linters to velodyne_driver #301

Merged
merged 4 commits into from
Nov 5, 2019
Merged

ROS2: Add Linters to velodyne_driver #301

merged 4 commits into from
Nov 5, 2019

Conversation

JWhitleyWork
Copy link
Contributor

Adds ROS2 common linters. Fixes all suggestions. Re-enables diagnostic_updater.

@JWhitleyWork JWhitleyWork changed the title ROS2: Add Lint/SA to velodyne_driver ROS2: Add Linters to velodyne_driver Nov 3, 2019
@JWhitleyWork JWhitleyWork mentioned this pull request Nov 3, 2019
Closed
4 tasks
clalancette
clalancette approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one suggestion for improvement, but I'll leave it up to you whether to fix this now or do it in a follow-up.

velodyne_driver/src/driver/driver.cpp Outdated Show resolved Hide resolved
@JWhitleyWork
Copy link
Contributor Author

Also, thanks, @clalancette for all of the reviews!

@JWhitleyWork JWhitleyWork merged commit cae2820 into dashing-devel Nov 5, 2019
@JWhitleyWork JWhitleyWork deleted the maint/add_lint_velodyne_driver branch November 5, 2019 23:58
@clalancette clalancette mentioned this pull request Nov 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JWhitleyWork @clalancette