Dashing fixes #307
Merged
Dashing fixes #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us get rid of calls to 'new', and is the more modern way to store unique pointers. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This really puts it back to what it used to be, which seems to fix a bug where the scans would be intermittent. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Since we are doing a std::move of the scan, we can't access the stamp afterwards to get the stamp. Store the stamp before we std::move it so we can use it later. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Without this, the published pointclouds get slower and slower. Just recalculate the row_step every time, which isn't really expensive anyway. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This has side-effects for the class, so we can't just eliminate it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
JWhitleyWork
approved these changes
Nov 6, 2019
|
@clalancette - Everything in this MR looks fine. Do you know if it solves the problem that @pjreed brought up in #298? |
I believe it should, but a confirmation would be great. |
|
Yep, I just tested it out and it looks much better now. Thanks! |
Fantastic, thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a bunch of fixes that I needed to make the current Dashing actually work with my VLP-16. With all of these in place, I'm now able to make this produce pointclouds as before. @JWhitleyAStuff please take a look, thanks!