feat: unify tf frame parameters between transform and cloud nodes #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers#344) * Unify tf frame parameters between transform and cloud nodes At this point there is no need any more for cloud node because transform node includes all features of cloud node. * Reformat code slightly to avoid roslint errors * Use boost bind instead of lambdas to add support for kinetic * Fix some search and replace errors in comments * Add fixed_frame and target_frame params back * Use more common ROS terminology instead of 'htm' * Undo renaming of publisher and subscriber * Just use tf listener when necessary * Migrate package to tf2 * Explicitly store sensor frame in a dedicated variable to make code easier to read * Reformat code slightly to avoid roslint errors * Avoid unnecessary transforms when sensor_frame == target_frame * Fix comments Co-authored-by: anre <andreas.reich@unibw.de>
|
@JWhitleyWork @clalancette friendly ping |
1 similar comment
|
@JWhitleyWork @clalancette friendly ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a part of #434
ros2 porting of #344
At this point there is no need any more for cloud node because transform node includes all features of cloud node.
Reformat code slightly to avoid roslint errors
Use boost bind instead of lambdas to add support for kinetic
Fix some search and replace errors in comments
Add fixed_frame and target_frame params back
Use more common ROS terminology instead of 'htm'
Undo renaming of publisher and subscriber
Just use tf listener when necessary
Migrate package to tf2
Explicitly store sensor frame in a dedicated variable to make code easier to read
Reformat code slightly to avoid roslint errors
Avoid unnecessary transforms when sensor_frame == target_frame
Fix comments
Co-authored-by: anre andreas.reich@unibw.de