Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modify some tests #452

Merged
merged 4 commits into from
Jul 18, 2022
Merged

fix: modify some tests #452

merged 4 commits into from
Jul 18, 2022

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Mar 4, 2022 •
edited
Loading

A part of #434
ros2 porting of #348

  • CI: Targeting Noetic.

  • CI: Trying to fix build crash.

  • Fixing new linter errors.

  • Changing command for running tests.

Signed-off-by: wep21 border_goldenmarket@yahoo.co.jp

CI: Target Noetic on Master (ros-drivers#348)
f9e2419 
* CI: Targeting Noetic.

* CI: Trying to fix build crash.

* Fixing new linter errors.

* Changing command for running tests.

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 changed the title fix: modify some test fix: modify some tests Mar 4, 2022
@wep21
Copy link
Contributor Author

wep21 commented Mar 4, 2022

FYI @clalancette @JWhitleyWork

@wep21
Copy link
Contributor Author

wep21 commented Mar 14, 2022

@clalancette @JWhitleyWork friendly ping

JWhitleyWork
JWhitleyWork requested changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@JWhitleyWork JWhitleyWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

velodyne_pointcloud/tests/CMakeLists.txt Outdated Show resolved Hide resolved
velodyne_pointcloud/tests/test_calibration.cpp Show resolved Hide resolved
wep21 added 2 commits March 22, 2022 11:29
remove relative file path
b420863 
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
remove unnecessary main
bbd8a9a 
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 requested a review from JWhitleyWork March 22, 2022 02:31
@wep21
Copy link
Contributor Author

wep21 commented Apr 1, 2022

@JWhitleyWork friendly ping

1 similar comment
@wep21
Copy link
Contributor Author

wep21 commented Jul 17, 2022

@JWhitleyWork friendly ping

JWhitleyWork
JWhitleyWork reviewed Jul 17, 2022
View reviewed changes
Copy link
Contributor

@JWhitleyWork JWhitleyWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last question

velodyne_pointcloud/tests/test_calibration.cpp Show resolved Hide resolved
fix: restore hdl64e s2 float intensities test
9670788 
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 requested a review from JWhitleyWork July 17, 2022 23:59
@JWhitleyWork JWhitleyWork merged commit 37a2b71 into ros-drivers:ros2 Jul 18, 2022
@wep21 wep21 deleted the fix-test branch July 18, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JWhitleyWork JWhitleyWork JWhitleyWork approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wep21 @JWhitleyWork