New service to calculate a route between two GeoPoints #1
Conversation
|
I'll review this along with the other tomorrow. Thanks for contributing! |
|
I am interested in your application. All of these interfaces are still experimental. They need real-world use cases. Unfortunately, I have not actively been using them for quite some time.
I'd been assuming that low-level navigation should use nav_msgs/GetPlan directly, with the UTM coordinates as points. |
|
Our application is described in http://www.rts.uni-hannover.de/images/4/43/Langerwisch12b-ICIRA.pdf. This year we added more robots, which are full ROS integrated. The outdoor robots are navigate using OSM map and GPS receiver. I'm used GeoPoint for planning, because the GUI in our application sends the goal way points as lat/lon. The robot is localized by GPS (gps_common/GPSFix) and OSM map contains lat/lon. For low-level navigation the path is transformed to nav_msgs/GetPlan. I'm not commited this method. Maybe I could add another service for this purpose... |
|
Very interesting project, well-suited for OSM maps. I hope some of those packages prove useful to you. I guess you are not using It should be fairly easy to create your own way-points on the fly and add them to the map. I don't know if that would be useful to you or not. It does provide a nice way to navigate from some arbitrary lat/long to an existing, labelled, map way-point. I have no objection to adding your new service, given that you find it useful. I suggest also adding an explicit |
|
Since these packages are still very experimental, I would like to add you to the ros-geographic-info github project as a developer. Is that all right with you? Also, it would help for you to join our geographicinfo-devel mailing list. It's still hosted on kforge.ros.org. I suppose we should move it to a Google group like all the other ROS SIGs have done. You might find this thread interesting. |
|
Don't bother with the old mailing list. I created a new one on Google groups. You should receive an invitation, if I did it correctly. There is also a SIG page here: |
|
The geographic_info and open_street_map packages were a great help for me. Thanks a lot! I'm also joined to the new SIG, thank you for invitation. The extension with It right for me, if you add me as developer of ros-geographic-info github project. Regards, |
|
Alex, Any new developments for this PR? Are you waiting on me to do something? |
|
Sorry, because of other projects I'm currently not ready with the implementation of the new interface. It might still take a couple months until I can develop on this project again... |
|
Take your time. I just wanted to make sure you were not waiting on me. If I see a pull request open for so long, I worry that I forgot to do something. |
removing references to the old/deprecated geodesy.gen_uuid as described
|
@atiderko , any interest in giving a go to this PR again? I know it's been some time but I'd like to prepare a release soon for Kinetic and Lunar |
|
@bmagyar thanks for the ping! It's some time since we worked with this package, but i'm interested in include this part of code. I or my college will see, how to resolve the conflicts of this pull request. But next week ;) |
|
Perhaps it would be easier to cherry pick on a fresh checkout, I see there
has been several "update to upstream"s that may give you their own
conflicts for no gain.
…On Nov 17, 2017 11:50, "Alexander Tiderko" ***@***.***> wrote:
@bmagyar <https://github.com/bmagyar> thanks for the ping! It's some time
since we worked with this package, but i'm interested in include this part
of code. I or my college will see, how to resolve the conflicts of this
pull request. But next week ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADXH4SjQlEq1Cqm7HOG6kQ5oi2VwcTwCks5s3XLygaJpZM4Ao2q3>
.
|
|
Hi @bmagyar, I've discussed this with my colleague @atiderko and we are preparing a new pull request from a fresh fork. It addresses all the changes made on this PR and solves the conflicts. I will have it ready in a couple of days, and then if you'd like, this PR can be ignored so that you review the new one. Cheers, |
|
Great, thanks guys!
…On 22 November 2017 at 13:14, Diego Ramos ***@***.***> wrote:
Hi @bmagyar <https://github.com/bmagyar>, I've discussed this with my
colleague @atiderko <https://github.com/atiderko> and we are preparing a
new pull request from a fresh fork. It addresses all the changes made on
this PR and solves the conflicts. I will have it ready in a couple of days,
and then if you'd like, this PR can be ignored so that you review the new
one.
Cheers,
Diego
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADXH4S9P2i_sxtV9Dj_z3qxzt3ChXCY-ks5s5B4vgaJpZM4Ao2q3>
.
|
|
Closing in favour of #10 |
Hi,
based on your open_street_map package I added the calculation of a route between two GeoPoints. In this context a new service was added to geographic_msgs, see ros-geographic-info/geographic_info#7
I thought maybe that needs someone ...
Regards,
Alex