Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABB IRB6700 support package #105

Merged
merged 4 commits into from
Feb 26, 2019

Conversation

marip8
Copy link
Member

@marip8 marip8 commented Dec 4, 2018

Support package for the 235 2.65 variant of the ABB IRB6700

Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. Minor changes requested.

abb_irb6700_support/package.xml Outdated Show resolved Hide resolved
abb_irb6700_support/package.xml Outdated Show resolved Hide resolved
abb_irb6700_support/urdf/irb6700_235_265_macro.xacro Outdated Show resolved Hide resolved
abb_irb6700_support/urdf/irb6700_235_265_macro.xacro Outdated Show resolved Hide resolved
abb_irb6700_support/urdf/irb6700_235_265_macro.xacro Outdated Show resolved Hide resolved
abb_irb6700_support/urdf/irb6700_235_265_macro.xacro Outdated Show resolved Hide resolved
@gavanderhoorn
Copy link
Member

@marip8: what is the status of this PR?

@marip8
Copy link
Member Author

marip8 commented Feb 26, 2019

@gavanderhoorn The changes you requested are addressed in the last 2 commits, so it should be good to merge. Not sure where the merge commit came from; I can try to rebase or squash that commit if necessary

@gavanderhoorn
Copy link
Member

@gavanderhoorn The changes you requested are addressed in the last 2 commits, so it should be good to merge. Not sure where the merge commit came from; I can try to rebase or squash that commit if necessary

I'll squash-merge.

Just fixed a minor issue. Let's wait on Travis and we'll merge.

@gavanderhoorn
Copy link
Member

Travis completed successfully (but took its time), so merging.

@gavanderhoorn gavanderhoorn merged commit f8e2bf9 into ros-industrial:kinetic-devel Feb 26, 2019
@gavanderhoorn
Copy link
Member

Thanks @marip8 for submitting the PR 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants