Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rapid_msgs: remove non-ascii characters #9

Merged
merged 1 commit into from
Mar 10, 2021
Merged

rapid_msgs: remove non-ascii characters #9

merged 1 commit into from
Mar 10, 2021

Conversation

gavanderhoorn
Copy link
Member

As per subject.

@gavanderhoorn
rapid_msgs: remove non-ascii characters
e17c854 
These were probably copied from a documentation PDF and caused problems when building the package on Windows.
@gavanderhoorn
Copy link
Member Author

This is for ros-industrial/abb_robot_driver#17.

@gavanderhoorn gavanderhoorn mentioned this pull request Mar 4, 2021
Open
@gavanderhoorn
Copy link
Member Author

Seems this is at least needed on some systems, and avoiding unicode in ROS .msgs is a good thing to do in any case.

@jontje: could you take a look?

jontje
jontje approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@jontje jontje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@gavanderhoorn gavanderhoorn merged commit fa230a0 into ros-industrial:master Mar 10, 2021
@gavanderhoorn gavanderhoorn deleted the remove_non_ascii branch March 10, 2021 11:56
@gavanderhoorn
Copy link
Member Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jontje jontje jontje approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavanderhoorn @jontje