-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Clarification in readme (partly addresses #24). #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
130s
force-pushed
the
doc/up_down_stream
branch
2 times, most recently
from
April 19, 2016 23:42
4d8a265
to
9865c7b
Compare
Also better address a comment moveit/moveit_core#285 (comment) |
130s
force-pushed
the
doc/up_down_stream
branch
2 times, most recently
from
May 27, 2016 18:48
81e811b
to
9f67aed
Compare
130s
force-pushed
the
doc/up_down_stream
branch
5 times, most recently
from
June 5, 2016 04:51
1ae429a
to
4020de5
Compare
…trial#24). Simply variables.
Now I feel like moving forward with this documentation update. Could anyone review? |
@davetcoleman would you mind reviewing this since you've opened PRs before to readme? |
+1 I skimmed through the changes, but I need to focus my efforts on MoveIt! |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically this PR tries to add various clarification to readme.rst.
This PR originally tried to address the concern raised at #24 (comment)