Rebased 190: export compiler flags #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced with definitions prefixed with the package name. The old definitions are still present to avoid breaking any user code that checks them.
So restore it.
now that it's available.
tcd == target compile definition. Instead of automatically (and unconditionally) adding these to the include(..)-ing context, define a variable which can be used with target_compile_definitions(..) by dependents.
Compile IRC libs with the same flags.
All dependents must also use these if they include any simple_message and/or IRC public headers.
gavanderhoorn
force-pushed
the
rebased_export_compiler_flags
branch
from
603decc
to
22bcc1c
Compare
|
Note: this does require dependents to actively use the exported I'll prepare a PR against |
|
@JeremyZoss @Levi-Armstrong: if either of you could review? As this is now a PR I opened I cannot review it myself. |
Levi-Armstrong
approved these changes
Jun 22, 2021
|
Thanks @Levi-Armstrong 👍 |
This was referenced Jun 22, 2021
gavanderhoorn
added a commit
to gavanderhoorn/industrial_core
that referenced
this pull request
Jul 15, 2021
This adds some bw-compatibility to the changes merged in ros-industrial#262. Remove these in noetic-devel.
gavanderhoorn
added a commit
that referenced
this pull request
Jul 15, 2021
This adds some bw-compatibility to the changes merged in #262. Remove these in noetic-devel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #190 (which addresses #188), combined with a migration to a more scalable solution (which itself is a compromise between how we'd like to do it (with modern CMake) and what Catkin supports in ROS 1).
I opted to include additional commits in this rebased PR as the basic principle (use a
CFG_EXTRASfile to export-Dflags to dependents) is still used. The file just doesn't set those flags directly, that's left up to the dependent.I've also opted to remove the old defines (ie:
ROS,MOTOPLUSandLINUXSOCKETS) instead of keeping them around.They were really only used with early versions of MotoROS and we don't want to have them lingering around.