-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebased 190: export compiler flags #262
Rebased 190: export compiler flags #262
Conversation
Replaced with definitions prefixed with the package name. The old definitions are still present to avoid breaking any user code that checks them.
So restore it.
now that it's available.
tcd == target compile definition. Instead of automatically (and unconditionally) adding these to the include(..)-ing context, define a variable which can be used with target_compile_definitions(..) by dependents.
Compile IRC libs with the same flags.
All dependents must also use these if they include any simple_message and/or IRC public headers.
603decc
to
22bcc1c
Compare
Note: this does require dependents to actively use the exported I'll prepare a PR against |
@JeremyZoss @Levi-Armstrong: if either of you could review? As this is now a PR I opened I cannot review it myself. |
Thanks @Levi-Armstrong 👍 |
This adds some bw-compatibility to the changes merged in ros-industrial#262. Remove these in noetic-devel.
This adds some bw-compatibility to the changes merged in #262. Remove these in noetic-devel.
This is a rebase of #190 (which addresses #188), combined with a migration to a more scalable solution (which itself is a compromise between how we'd like to do it (with modern CMake) and what Catkin supports in ROS 1).
I opted to include additional commits in this rebased PR as the basic principle (use a
CFG_EXTRAS
file to export-D
flags to dependents) is still used. The file just doesn't set those flags directly, that's left up to the dependent.I've also opted to remove the old defines (ie:
ROS
,MOTOPLUS
andLINUXSOCKETS
) instead of keeping them around.They were really only used with early versions of MotoROS and we don't want to have them lingering around.