Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildstep configurations are not accessible #444

Closed
v4hn opened this issue Sep 16, 2021 · 5 comments · Fixed by #447
Closed

buildstep configurations are not accessible #444

v4hn opened this issue Sep 16, 2021 · 5 comments · Fixed by #447

Comments

@v4hn
Copy link
Contributor

v4hn commented Sep 16, 2021

I just wanted to set the number of build jobs in my qt-creator build configuration and found no way to do that.
The build step configurations for the ROS build steps have been empty for as long as I've used the plugin.
This is what I see in the build config screen over here:

buildstep-config

Notice the various options available in the IncrediBuild step (I just added that for illustration).

Looking at the plugin code though, it looks like there is quite a bit of code dedicated to UI options for these steps including jobs and various others! See here for catkin_tools.
But there does not seem to be anything even instantiating the class.

Is this yet another API that got deprecated and removed in qt-creator at some point?
I have no idea whether it's one line missing or requires an entire rewrite, but it would be great to see these configurations available!

@christian-rauch @Levi-Armstrong ?

@Levi-Armstrong
Copy link
Member

In the older version under the catkin, tools step you could select the Edit... button which would bring this widget up for editing catkin tools profiles.

image

image

@christian-rauch
Copy link
Member

christian-rauch commented Sep 16, 2021

It's totally possible that this got removed accidentally by me during one of the many API transitions. I never noticed that, since I am not using that functionality. Do you know with which version this functionality disappeared?

Edit: I tested the old 4.9.2 installer and I see the options there. So this definitely broke with one of the API transitions. But there were 7 of them (4.{10...15}, 5.0), so it will take some time to figure out which update broke this functionality.

@Levi-Armstrong
Copy link
Member

I am currently on 4.9.2 which has this functionality.

@christian-rauch
Copy link
Member

I assume that this broke with 59ac8cd. It should work with 4.13 and not with 4.14.

@christian-rauch
Copy link
Member

christian-rauch commented Sep 22, 2021

@v4hn Can you check if #447 solves this issue for you? It should add the configuration widgets again and undo some of the changes from 59ac8cd. You can download the plugin archive from the build artefacts at: https://github.com/ros-industrial/ros_qtc_plugin/actions/runs/1261301357.

Edit: plugin archive from CI: ROSProjectManager-0.4.0-Linux-x86_64.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants