Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port to Qt Creator 6.0 #456

Merged
merged 23 commits into from
Dec 20, 2021
Merged

port to Qt Creator 6.0 #456

merged 23 commits into from
Dec 20, 2021

Conversation

christian-rauch
Copy link
Member

@christian-rauch christian-rauch commented Oct 18, 2021 •
edited
Loading

This is the initial port for Qt Creator 6 Beta. I am going to keep this as a draft until it has been officially released. But you can already review and comment now.

Port for Qt Creator 6.

Notable changes are:

  1. switch to Qt6
  2. temporary deactivation of the ROS Terminal (qtermwidget) due to missing support for Qt6, I tried to use the Qt5 version but this seem to crash Qt Creator with something related to the Qt5 compatibility layer
  3. without qtermwidget, which is not available on Windows, I am also building the Windows plugin in the CI, the plugin itself does not load correctly, presumably because if missing symbols, but having the CI run with MSVC already provides some useful warnings and error messages

@christian-rauch christian-rauch marked this pull request as draft October 18, 2021 17:04
@christian-rauch christian-rauch changed the title port to Qt Creator 6.0 beta port to Qt Creator 6.0 Dec 4, 2021
@christian-rauch christian-rauch marked this pull request as ready for review December 4, 2021 01:54
@christian-rauch
Copy link
Member Author

@Levi-Armstrong Can you have a look at this PR and suggest a way how we can go forward without the qtermwidget?

@christian-rauch
Copy link
Member Author

@Levi-Armstrong Can you have a look at this? The removal of the qtermwidget5 effectively disables ROSGenericRunStep, but according to #459, this is broken anyway for a while now.

I think the "Run Settings" for rosrun, roslaunch, ros2 run, ros2 launch, etc. need to be implemented anyway. So we are not losing any features by removing the qtermwidget5.

@christian-rauch
build and link static yaml-cpp from source
80ec5a0
@christian-rauch
remove the runtime dependencies for installation of official plugin a…
a688df6 
…rchive

The official archive from the CI builds and links 'yaml-cpp' statically. It
is therefore not required anymore at runtime. 'qtermwidget' has been
deactivated for now.
@christian-rauch christian-rauch merged commit f1752fc into ros-industrial:devel Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Levi-Armstrong Levi-Armstrong Levi-Armstrong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christian-rauch @Levi-Armstrong