Replace __ prefixes

[fmauch]

With newer versions of xacro this leads to errors otherwise.

Also see UniversalRobots/Universal_Robots_ROS_Driver#463 and ros/xacro@9941961

[danielcranston]

Is there anything preventing this from being merged? As I see it melodic-devel-staging is basically broken (processing any robot with xacro will fail) until this is merged.

[gavanderhoorn]

This is already fixed in fmauch/universal_robot, which is the version which should be used with UniversalRobots/Universal_Robots_ROS_Driver.

[danielcranston]

fmauch/universal_robot, which is the version which should be used with UniversalRobots/Universal_Robots_ROS_Driver.

Unfortunately UniversalRobots/Universal_Robots_ROS_Driver seems to be of a different opinion:
https://github.com/UniversalRobots/Universal_Robots_ROS_Driver/blob/master/.melodic.rosinstall#L4

Could you link to where it's explained that the fmauch fork is the intended version? (I thought the rosinstall file was the source of truth)

[gavanderhoorn]

See UniversalRobots/Universal_Robots_ROS_Driver#463 and fmauch#18.

[fmauch]

fmauch/universal_robot, which is the version which should be used with UniversalRobots/Universal_Robots_ROS_Driver.

Unfortunately UniversalRobots/Universal_Robots_ROS_Driver seems to be of a different opinion:
https://github.com/UniversalRobots/Universal_Robots_ROS_Driver/blob/master/.melodic.rosinstall#L4

Could you link to where it's explained that the fmauch fork is the intended version? (I thought the rosinstall file was the source of truth)

I am about to create a PR for the driver using my fork again. Sorry for the current situation, we hope to straighten the UR support situation soon.