Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing dependency for moveit_simple_controller_manager #236

Merged

Conversation

fmessmer
Copy link
Contributor

moveit_plugins brings in the dependency to moveit_simple_controller_manager (see rosdistro)

fixes #225

@gavanderhoorn
Copy link
Member

moveit_plugins is a metapackage, and iirc using that for run or build dependencies is considered not done (depending on transitive dependencies for your direct dependencies is not recommended).

Would it perhaps make sense to just add moveit_simple_controller_manager directly?

@fmessmer
Copy link
Contributor Author

$ rosdep install --from-paths src -i
executing command [sudo -H apt-get install ros-indigo-moveit-plugins]
[sudo] password for fxm: 
Reading package lists... Done
Building dependency tree       
Reading state information... Done
The following extra packages will be installed:
  ros-indigo-moveit-ros-control-interface
  ros-indigo-moveit-simple-controller-manager
The following NEW packages will be installed:
  ros-indigo-moveit-plugins ros-indigo-moveit-ros-control-interface
  ros-indigo-moveit-simple-controller-manager
0 upgraded, 3 newly installed, 0 to remove and 5 not upgraded.
Need to get 0 B/298 kB of archives.
After this operation, 1,646 kB of additional disk space will be used.
Do you want to continue? [Y/n]

@gavanderhoorn
Copy link
Member

I'm not saying it won't work, just that it is not recommended.

@gavanderhoorn
Copy link
Member

From REP-127 - fi:

Metapackages may not install any code or other files, although package.xml does get installed automatically. They can depend on other metapackages, if desired, but regular catkin packages cannot.

and:

Catkin packages must depend directly on the packages they use, not on any metapackages.

@fmessmer fmessmer merged commit e122ccc into ros-industrial:indigo-devel Apr 1, 2016
@fmessmer fmessmer deleted the fix_missing_dependency branch April 1, 2016 13:59
ipa-nhg pushed a commit to ipa-nhg/universal_robot that referenced this pull request Jul 2, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants