Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: PR #358 rebased for melodic devel staging #589

Open
wants to merge 7 commits into
base: melodic-devel-staging
Choose a base branch
from

Conversation

dhled
Copy link

@dhled dhled commented Sep 29, 2021

Rebased version of #358 to target to melodic-devel-staging

Not tested yet.

Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this PR should really only touch ur_kinematics. All changes to other packages should be removed / avoided.

Also: changes to CHANGELOGs (and similar files) should also not be included.

I realise this may not be trivial (due to this being a rebase).

@gavanderhoorn
Copy link
Member

@dhled: would you see an opportunity to fix the PR?

@dhled
Copy link
Author

dhled commented Oct 5, 2021

Yes, I will try to do that this week.

Jonathan Meyer and others added 7 commits October 8, 2021 11:46
…full range of joint limits.

Rotates joint by +-360° if it is possible and gets the solution closer to the seed.
Co-authored-by: Simon Schmeisser <s.schmeisser@gmx.net>
Co-authored-by: Simon Schmeisser <s.schmeisser@gmx.net>
@dhled
Copy link
Author

dhled commented Oct 8, 2021

I still need to test on UR and UR-E, I will try to that later today / tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants