readd flake8_docstrings, add flake8_class_newline (#795)

.travis.yml

@@ -47,7 +47,7 @@ jobs:
     - python: "3.6"
       install:
         - pip install catkin-pkg EmPy jenkinsapi PyYAML rosdistro vcstool
-        - pip install flake8 flake8-import-order pep8 pyflakes pytest
+        - pip install flake8 flake8-class-newline flake8-docstrings flake8-import-order pep8 pyflakes pytest
       script:
         - py.test -s test
     - python: "3.6"

ros_buildfarm/argument.py

@@ -235,6 +235,7 @@ def add_argument_not_failed_only(parser):
 
 def add_argument_os_code_name_and_arch_tuples(parser, required=True):
     class _AddUbuntuTupleAction(argparse.Action):
+
         def __call__(self, parser, args, values, option_string=None):
             import sys
             print('WARNING: ' + self.help, file=sys.stderr)
@@ -465,6 +466,7 @@ def add_argument_testing(parser):
 
 def check_len_action(minargs, maxargs):
     class CheckLength(argparse.Action):
+
         def __call__(self, parser, args, values, option_string=None):
             if len(values) < minargs:
                 raise argparse.ArgumentError(
@@ -480,6 +482,7 @@ def __call__(self, parser, args, values, option_string=None):
 
 def colon_separated_tuple_action(numparts):
     class ColonSeparatedTupleAction(argparse.Action):
+
         def __call__(self, parser, args, values, option_string=None):
             for value in values:
                 if value.count(':') + 1 != numparts:
@@ -509,6 +512,7 @@ def extract_multiple_remainders(argv, arguments):
 
 
 class OrderedDictAction(argparse.Action):
+
     def __call__(self, parser, args, values, option_string=None):
         dest = OrderedDict()
         for value in values:

ros_buildfarm/common.py

@@ -44,8 +44,7 @@ def __init__(self, message):  # noqa: D107
 
 class PlatformPackageDescriptor(str):
     """
-    Represents a package stored in a platform-specific package
-    repository.
+    Represents a package stored in a platform-specific package repository.
 
     Currently the class is inheriting from str for backwards compatibility.
     You should not rely on this but use the `version` property instead.
@@ -58,7 +57,7 @@ class PlatformPackageDescriptor(str):
     def __new__(cls, version, source_name):
         return str.__new__(cls, version)
 
-    def __init__(self, version, source_name):
+    def __init__(self, version, source_name):  # noqa: D107
         self.source_name = source_name
 
     @property

ros_buildfarm/config/ci_build_file.py

@@ -20,7 +20,7 @@ class CIBuildFile(BuildFile):
 
     _type = 'ci-build'
 
-    def __init__(self, name, data):
+    def __init__(self, name, data):  # noqa: D107
         assert 'type' in data, "Expected file type is '%s'" % \
             CIBuildFile._type
         assert data['type'] == CIBuildFile._type, \

ros_buildfarm/config/plot_config.py

@@ -15,7 +15,7 @@
 
 class PlotConfig:
 
-    def __init__(self, name, data):
+    def __init__(self, name, data):  # noqa: D107
         self.name = name
 
         assert 'master_csv_name' in data, \
@@ -61,7 +61,7 @@ def __init__(self, name, data):
 
 class PlotDataSeries:
 
-    def __init__(self, name, data):
+    def __init__(self, name, data):  # noqa: D107
         self.name = name
 
         assert 'data_file' in data, \

ros_buildfarm/pulp.py

@@ -42,7 +42,7 @@ def _enumerate_recursive_dependencies(packages, target_names):
 
 class PulpPageIterator:
 
-    def __init__(self, fetch_function, *args, **kwargs):
+    def __init__(self, fetch_function, *args, **kwargs):  # noqa: D107
         self._get_next = lambda offset: fetch_function(*args, **kwargs, offset=offset)
         self._offset = 0
         self._next_page()
@@ -72,7 +72,8 @@ def __next__(self):
 class PulpRpmClient:
 
     def __init__(
-            self, base_url, username, password, task_timeout=60.0, task_polling_interval=0.5):
+            self, base_url, username, password,
+            task_timeout=60.0, task_polling_interval=0.5):  # noqa: D107
         self._task_timeout = task_timeout
         self._task_polling_interval = task_polling_interval
 

setup.py

@@ -34,6 +34,8 @@
         'PyYAML'],
     'tests_require': [
         'flake8 >= 3.7',
+        'flake8_class_newline',
+        'flake8_docstrings',
         'flake8_import_order',
         'pep8',
         'pyflakes'],