-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the abichecker run on devel builds #681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will leave it up to @nuclearsandwich to recommend how to test deploy this.
Btw. the current state severely breaks CI which needs to be address before it even makes sense to test deploy this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from one comment which can go either way, I think this is ready. Thanks for iterating @j-rivero.
Not sure what happened with Travis but seems like it is not running on my last changes. I can promise that they pass :) . After/before the merge we need to install the Jenkins plugins: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j-rivero Please squash merge whenever is ok (not sure of the Jenkins masters need to be updated before, probably not since no repo uses the new flag?).
The PR tries to implement the ABI checking for ROS2 packages (issue #678).
The approach followed was to use implement the option of abi checking in the
build_and_install.py
script used by the devel scripts. I've implement an argument in the script named--abi-checker
that runs the auto-abi-checker tool using:Testing:
build_and_install.py
script directly on my local system the runs of simple packages (rclcpp
) was succesful.Open questions and TODO:
.h
or.so
the checker will probably do nothing and report success.auto-abi-checker
.gazebo_ros_pkgs
) that introduce boost headers into the mix of headers to check (some expected definitions are missing). I'm still investigating them.