-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace 404 Issue reporting link with Issue Form #362
Comments
Hello @tfoote Looking forward to your response! Thanks |
It would be great if you wanted to take this one. I'll be happy to review PRs to change this. In addition to making the form you'd want the link to point to it. The link is here in the code: https://github.com/ros-infrastructure/rosindex/blob/ros2/404.html I've linked the above layout. Examples of the problematic pull requests can be found by searching broken link is:closed: https://github.com/ros-infrastructure/rosindex/issues?q=is%3Aissue+is%3Aclosed+broken+link In the best case you could find a way to automatically detect what url the 404 was attempting to go to so the form only has to collect the source location from the user. In the form I'd ask that you get both the linking page url as well as the link text for easier finding to try to find the link if the page is long. |
Hi @tfoote |
Hi @tfoote I've been considering the structure of the form for reporting broken links. Here's what I've could come up with: Form StructureI propose the following fields for the form:
Looking forward to your thoughts on this approach. |
That looks good, though I would drop the email submission. They can be contacted via the issue on GitHub which will be reported by their user. So any comment back on the issue will give them a notification. Using JavaScript to get the 404 URL automatically would be great. You might add that to the generated title too. |
Hello @tfoote, I encountered some initial hiccups with Docker on my machine, but it looks like everything is sorted out now, and I'm ready to kick off my development work. I'll be working on addressing this issue and plan to submit a pull request within the next few days. Thanks for your patience! |
Thanks for working on this @gabrielhsdev I'm going to close this as resolved by the PR. |
The new Issue Form is a good way to get reports with better syntax.
We've had a lot of empty broken link issues recently which are just noise for us and not satisfying for the people taking the effort to file them.
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms
The text was updated successfully, but these errors were encountered: