-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add velocities and torques to the joint states #113
Conversation
Hi, thanks for contributing! |
@Pandhariix what do you think about maintaining naoqi_driver ? |
@nlyubova, I think it could be interesting |
@Pandhariix please give me your mail address to add you as a maintainer |
@Pandhariix you are maintainer now ! congratulations ! |
Hi @nlyubova, I just realized that this PR was left pending... Should we merge it ? |
Hi Maxime, For me it's fine to merge whatever you have Natalia |
ah, actually there are some builds failing. and let me know if I could help you |
Alright, I'll merge it then. I checked the CI builds:
|
ok, I see Then, let's merge it! and let me know if you need any help for other PR |
I tried to add a quick fix for the Indigo CI, it didn't do the trick. It would seem that the problem comes from Indigo... I reverted the CI changes, I suggest that we merge the pull request, I'll fix the indigo CI in a dedicated PR |
anyway, fine for me |
Adding velocity values and torque values to the joint states.
For a specific joint, if the velocity (and respectively the torque) value is provided, it is included in the velocity (respectively effort) list of the joint state message. If not, a nan is added to the velocity (respectively effort) list. The velocity information is for instance provided for Pepper's LShoulderPitch, but not for its LHand.