Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add velocities and torques to the joint states #113

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Add velocities and torques to the joint states #113

merged 1 commit into from
Dec 3, 2019

Conversation

mbusy
Copy link
Member

@mbusy mbusy commented Jun 26, 2019

Adding velocity values and torque values to the joint states.

For a specific joint, if the velocity (and respectively the torque) value is provided, it is included in the velocity (respectively effort) list of the joint state message. If not, a nan is added to the velocity (respectively effort) list. The velocity information is for instance provided for Pepper's LShoulderPitch, but not for its LHand.

@nlyubova
Copy link
Member

nlyubova commented Jul 1, 2019

Hi, thanks for contributing!

@nlyubova
Copy link
Member

nlyubova commented Jul 1, 2019

@Pandhariix what do you think about maintaining naoqi_driver ?

@mbusy
Copy link
Member Author

mbusy commented Jul 2, 2019

@nlyubova, I think it could be interesting

@nlyubova
Copy link
Member

nlyubova commented Jul 7, 2019

@Pandhariix please give me your mail address to add you as a maintainer

@mbusy
Copy link
Member Author

mbusy commented Jul 8, 2019

@nlyubova
Copy link
Member

nlyubova commented Jul 8, 2019

@Pandhariix you are maintainer now ! congratulations !

@mbusy
Copy link
Member Author

mbusy commented Dec 3, 2019

Hi @nlyubova, I just realized that this PR was left pending... Should we merge it ?

@nlyubova
Copy link
Member

nlyubova commented Dec 3, 2019

Hi Maxime,
I left it for you to merge.

For me it's fine to merge whatever you have

Natalia

@nlyubova
Copy link
Member

nlyubova commented Dec 3, 2019

ah, actually there are some builds failing.
Do you know why? could you fix it? (if it's fixable)

and let me know if I could help you

@mbusy
Copy link
Member Author

mbusy commented Dec 3, 2019

Alright, I'll merge it then. I checked the CI builds:

  • The lunar builds always fail, because naoqi_libqicore is not available for lunar (see this PR), we can't fix that from naoqi_driver.
  • The indigo build fails, and that's not normal. I had something similar a while ago, I'll investigate

@nlyubova
Copy link
Member

nlyubova commented Dec 3, 2019

ok, I see

Then, let's merge it! and let me know if you need any help for other PR

@mbusy
Copy link
Member Author

mbusy commented Dec 3, 2019

I tried to add a quick fix for the Indigo CI, it didn't do the trick. It would seem that the problem comes from Indigo... I reverted the CI changes, I suggest that we merge the pull request, I'll fix the indigo CI in a dedicated PR

@nlyubova
Copy link
Member

nlyubova commented Dec 3, 2019

anyway, fine for me

@mbusy mbusy merged commit 3a4db0c into ros-naoqi:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants