Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass rosdep eol flag #123

Merged
merged 1 commit into from
Dec 3, 2019
Merged

pass rosdep eol flag #123

merged 1 commit into from
Dec 3, 2019

Conversation

mikaelarguedas
Copy link
Member

rosdep database is not up to date as these images have been EOL for a while.
Running rosdep update with the --include-eol-distros flag should hopefully fix the rosdep install error.

Travis should most likely fail the job when a command fail rather than trying to build anyway

Signed-off-by: Mikael Arguedas mikael.arguedas@gmail.com

@mikaelarguedas mikaelarguedas changed the title pass rosdep eol flag WIP pass rosdep eol flag Dec 3, 2019
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas mikaelarguedas changed the title WIP pass rosdep eol flag pass rosdep eol flag Dec 3, 2019
@mbusy
Copy link
Member

mbusy commented Dec 3, 2019

Nice, that will fix the CI. The indigo build still seems to fail, due to the use of std::nan, I'll switch to std::numeric_limits::quiet_NaN(), that should fix the issue.

EDIT:
There is apparently an issue with Orocos KDL for the kinetic build, do you have any idea why ?

@nlyubova
Copy link
Member

nlyubova commented Dec 3, 2019

Thanks Mikael !

@mikaelarguedas
Copy link
Member Author

There is apparently an issue with Orocos KDL for the kinetic build, do you have any idea why ?

Yeah just noticed that happened on master's latest commit 3a4db0c didnt look into it though 🤷‍♂️

@mbusy
Copy link
Member

mbusy commented Dec 3, 2019

That's weird, nothing seems to be related to KDL in that commit

@mbusy
Copy link
Member

mbusy commented Dec 3, 2019

In any case this will fix the rosdep issue, thanks for the contrib Mikael!

@mbusy mbusy merged commit 198a498 into master Dec 3, 2019
@mikaelarguedas mikaelarguedas deleted the rosdep_eol branch December 3, 2019 13:05
@mikaelarguedas
Copy link
Member Author

That's weird, nothing seems to be related to KDL in that commit

Yeah my guess is mismatching package version (due to outdated images). like it's looking for a specific soabi of orocos libraries and thats not the same as the one in the image.
Testing a fix locally wil update a follow-up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants