Melodic compatibility #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! If less cumbersome when patching, Indigo has been EOL since April 2019 so new code and driver version will not be released for indigo and don't need to be compatible with indigo |
|
You're right... At some point we could even allow the CI to fail for indigo, or remove the indigo build from the CI. I guess I mentioned indigo because of the users running ROS on Nao's head (Nao V5 or older): as far as I know only indigo is compatible (excluding jade, etc), but they would still have access to the previously released naoqi_driver package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the driver's code for melodic compatibility, while ensuring backward compatibility with older distros (indigo, kinetic)