Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken compilation with libqi-2.5 #67

Merged
merged 1 commit into from
May 19, 2016

Conversation

suryaambrose
Copy link
Member

No description provided.

@suryaambrose
Copy link
Member Author

@severin-lemaignan this commit basically does the same thing as you, but makes it possible at the same time to use libqi 2.3 (cf ros-naoqi/libqi-release#3). I just forgot to add your -std=gnu++11 addition, how important is it ?

@k-okada
Copy link
Member

k-okada commented Mar 21, 2016

Hi, the patch seems ok to me, but I can not compile this on indigo, since ros-indigo-naoqi-libqicore is staill 2.3.1, i think.

[naoqi_driver] /usr/bin/c++   -DCATKIN_BUILD -DLIBQI_VERSION=25 -DROSCONSOLE_BACKEND_LOG4CXX -DROS_PACKAGE_NAME=\"naoqi_driver\" -Dnaoqi_driver_EXPORTS -std=gnu++11 -Werror=deprecated-declarations -fPIC -I/usr/include/opencv -I/home/k-okada/catkin_ws/ws_naoqi/src/naoqi_driver/include -I/opt/ros/indigo/include -I/usr/include/eigen3    -o CMakeFiles/naoqi_driver.dir/src/publishers/log.cpp.o -c /home/k-okada/catkin_ws/ws_naoqi/src/naoqi_driver/src/publishers/log.cpp 
[naoqi_driver] In file included from /opt/ros/indigo/include/qi/anyfunction.hpp:53:0,                                                
[naoqi_driver]                  from /opt/ros/indigo/include/qi/signal.hpp:12,                                                       
[naoqi_driver]                  from /opt/ros/indigo/include/qi/anyobject.hpp:15,                                                    
[naoqi_driver]                  from /home/k-okada/catkin_ws/ws_naoqi/src/naoqi_driver/include/naoqi_driver/tools.hpp:30,            
[naoqi_driver]                  from /home/k-okada/catkin_ws/ws_naoqi/src/naoqi_driver/src/converters/converter_base.hpp:24,         
[naoqi_driver]                  from /home/k-okada/catkin_ws/ws_naoqi/src/naoqi_driver/src/converters/log.hpp:24,                    
[naoqi_driver]                  from /home/k-okada/catkin_ws/ws_naoqi/src/naoqi_driver/src/converters/log.cpp:18:                    
[naoqi_driver] /opt/ros/indigo/include/qi/type/typeinterface.hpp:396:51: error: QI_TYPE_ENUM_REGISTER_ is deprecated (declared at /opt/ros/indigo/include/qi/type/typeinterface.hpp:387) [-Werror=deprecated-declarations] 
[naoqi_driver]        static const detail::QI_TYPE_ENUM_REGISTER_ BLAH;              \                                               
[naoqi_driver]                                                    ^                                                                  
[naoqi_driver] /opt/ros/indigo/include/qicore/logmessage.hpp:15:1: note: in expansion of macro QI_TYPE_ENUM_REGISTER                 
[naoqi_driver]  QI_TYPE_ENUM_REGISTER(qi::LogLevel)                   

@k-okada
Copy link
Member

k-okada commented Mar 21, 2016

Oh, this is already ticketed at ros-naoqi/libqicore-release#1

@suryaambrose
Copy link
Member Author

Yes, and those fixes are already pushed actually, but I forgot to update the distribution.yaml file in rosdistro which is why libqicore can still not compile. It is done now, so the package should be updated soon.

@suryaambrose
Copy link
Member Author

But anyway, naoqi_driver will not compile until I fixed this ros-naoqi/libqi-release#3

@suryaambrose suryaambrose merged commit 6a2faa4 into ros-naoqi:master May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants