Add joint limits to the diagnostics #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlyubova
requested changes
Nov 20, 2017
src/converters/diagnostics.cpp
Outdated
| @@ -65,6 +65,9 @@ DiagnosticsConverter::DiagnosticsConverter(const std::string& name, | |||
| p_body_temperature_.call<void>("setEnableNotifications", true); | |||
| } | |||
|
|
|||
| std::vector<std::vector<float> > jointLimits; | |||
There was a problem hiding this comment.
please use the naming convention: joint_limits
src/converters/diagnostics.cpp
Outdated
| @@ -65,6 +65,9 @@ DiagnosticsConverter::DiagnosticsConverter(const std::string& name, | |||
| p_body_temperature_.call<void>("setEnableNotifications", true); | |||
| } | |||
|
|
|||
| std::vector<std::vector<float> > jointLimits; | |||
| qi::AnyValue qiJointLimits; | |||
There was a problem hiding this comment.
please use the naming convention
|
Should be a bit better |
nlyubova
reviewed
Nov 20, 2017
src/converters/diagnostics.cpp
Outdated
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2015 Aldebaran | |||
| * Copyright 2017 Aldebaran | |||
There was a problem hiding this comment.
could you please keep this line as it is?
Add double layered float vector converter method Add the joints limit map, and add the joints limits to the diagnostic message
nlyubova
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the joint limits to the diagnostic message :