Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node name empty related to pepper_robot issue #35 #85

Merged
merged 2 commits into from
Apr 12, 2017

Conversation

PacoDu
Copy link
Contributor

@PacoDu PacoDu commented Apr 7, 2017

Related to pepper_robot issue #35
This is the fix I use to avoid node name empty and any namespace duplication like /pepper_robot/pepper_robot

Error while merging, setPrefix removed.
@nlyubova
Copy link
Member

Thank you!
It's fine for me. @suryaambrose would you agree to merge?

@suryaambrose
Copy link
Member

Sure :)

@suryaambrose suryaambrose merged commit f009c76 into ros-naoqi:master Apr 12, 2017
michieletto pushed a commit to michieletto/naoqi_driver that referenced this pull request May 24, 2017
Fix node name empty related to pepper_robot issue ros-naoqi#35
@nlyubova
Copy link
Member

nlyubova commented Jul 6, 2017

Great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants