Fix namespace to avoid duplication and node name empty #35 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@suryaambrose followed the merged PR in Naoqi Driver, should merge this one? |
|
I confirm that these modifications are necessary under Ubuntu 16.04 and ROS Kinetic. Otherwise, the depth and point cloud don't work. |
|
+1 I confirmed it under Ubuntu 14.04 and ros indigo. |
|
@suryaambrose what do you think? |
|
ok for me ! |
|
@nlyubova @suryaambrose |
|
@PacoDu could you please git pull and rebase? |
|
@nlyubova @suryaambrose What is the status on this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #35 and naoqi_driver PR #85