Fix loading of stopped goal checker. #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkhansenbot
requested review from
mkhansenbot,
mhpanah,
mjeronimo and
orduno
mjeronimo
approved these changes
Nov 20, 2018
ghost
pushed a commit
to logivations/navigation2
that referenced
this pull request
Mar 7, 2022
* created drone config * fixes #2 * changes to drone ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
stopped_goal_checkerlibrary was not getting the dependency on thelibsimple_goal_checker.soset by theament_target_dependenciescall. That call is only appropriate for external package dependencies. Dependencies that internal to the same package need to be specified using standard cmake.The symptom of this bug was that plugin lib failed to load
libstopped_goal_checker.soI wasn't able to properly test that this plug in stops the robot at the end due to the current defect in AMCL localization. There is a commit ( 91f47ec ) on the integtation-debug2 branch where I've enabled this by default, but I'm not sure if we want to put this on master. I figure on master, we should just set this parameter through the launch file