Fix the style throughout the codebase to conform to ROS 2 style. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no functional changes in here, only changes to the style. Also enable the linters so further contributions will have to conform. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
clalancette/fix-style
branch
from
4037e77
to
f883ae5
Compare
cottsay
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Same concern as ros/kdl_parser#66 (comment), but looks good otherwise. Hiding whitespace changes made this review a lot more manageable.
Using the same logic as in ros/kdl_parser#66 (comment) , I'm going to add the header and copyright holders to the LICENSE file. |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
cottsay
approved these changes
Jun 29, 2022
|
Rpr job is happy, and this is approved so going ahead and merging. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no functional changes in here, only changes to the
style.
Also enable the linters so further contributions will have
to conform.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org