Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the code to use a non-deprecated header. #72

Merged
merged 3 commits into from Jul 13, 2023
Merged

Update the code to use a non-deprecated header. #72

merged 3 commits into from Jul 13, 2023

Conversation

clalancette
Copy link
Contributor

This requires a little additional work, since Humble does not have that header.

@clalancette
Update the code to use a non-deprecated header.
b103b86 
This requires a little additional work, since Humble
does not have that header.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
tfoote
tfoote reviewed Jul 12, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
include/depthimage_to_laserscan/DepthImageToLaserScan.hpp Outdated Show resolved Hide resolved
cottsay
cottsay reviewed Jul 12, 2023
View reviewed changes
Copy link

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to bump to C++17 anyway, have you considered using __has_include instead?

https://en.cppreference.com/w/cpp/preprocessor/include

CMakeLists.txt Outdated Show resolved Hide resolved
@clalancette
Feedback from review.
3eeba6c 
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

If you're going to bump to C++17 anyway, have you considered using __has_include instead?

Oh, that's a good point. Let me give that a try.

@clalancette
Switch to using __has_include instead.
b176855 
That is available in C++17 and newer.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

Oh, that's a good point. Let me give that a try.

Oh yeah, that's much nicer. A much smaller patch that way. Thanks!

@clalancette clalancette merged commit f7b24c3 into ros2 Jul 13, 2023
4 checks passed
@clalancette clalancette deleted the clalancette/header-cleanup branch July 13, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote left review comments

@cottsay cottsay cottsay left review comments

@quarkytale quarkytale quarkytale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clalancette @tfoote @cottsay @quarkytale