Use a shared_ptr for the dynamic reconfigure pointer, and create it w… #358
Conversation
…ory> to make build system build it anyhow), also use typedef for callback ros-perception#358
|
@lucasw - Thanks for the PR! I know this is a bit old but, would you mind removing your custom launch file and rebasing this on |
|
Wouldn't you rather take this as a boost shared_ptr, then have a separate PR that switches out all the boost shared_ptrs for all of image_pipeline? (created an issue #407) It seems odd to just have one std shared_ptr and then 40 boost shared_ptrs. |
|
@lucasw - That's a good point. Thanks for the update. Would you mind rebasing this on |
lucasw
force-pushed
the
image_pub_dr_private_namespace
branch
from
1e67767
to
b467ca1
Compare
…ory> to make build system build it anyhow), also use typedef for callback ros-perception#358
…ith the private node handle so that the parameters for the dynamic reconfigure server are in the private namespace and two image publishers can coexist in the same manager ros-perception#357
lucasw
force-pushed
the
image_pub_dr_private_namespace
branch
from
295ae7c
to
3427b70
Compare
|
I've removed the launch file, rebased to melodic, and squashed. I left a backup of the launch file for myself in https://github.com/lucasw/image_pipeline/tree/indigo_image_pub_dr_private_namespace . |
…e_namespace Use a shared_ptr for the dynamic reconfigure pointer, and create it w…
…ith the private node handle so that the parameters for the dynamic reconfigure server are in the private namespace and two image publishers can coexist in the same manager #357
This may break parameters that were set in the nodelet manager namespace as a workaround in some launch files out there.