[depth_image_proc/register] option to fill sparsity holes on upsampling #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues on upsampling operations in depth_image_proc/register
|
Hello, could any maintainer please comment or merge this PR? Many thanks! |
SteveMacenski
approved these changes
Nov 4, 2019
|
I've got some formatting and C++-y complaints but nothing technical. They can be fixed when I lint the ROS1 side in the near future. |
|
@SteveMacenski - I'm guessing you didn't intend for this to target |
|
That would be correct. I’ll add to my queue to revert and retarget to melodic |
abhijitmajumdar
added a commit
to abhijitmajumdar/image_pipeline
that referenced
this pull request
Feb 17, 2021
…tion#478 (ros-perception#477, ros-perception#363), when registering depth image to rgb image with different intrinsics
schornakj
added a commit
to schornakj/image_pipeline
that referenced
this pull request
Aug 20, 2021
Signed-off-by: Joe Schornak <joe.schornak@gmail.com>
clalancette
pushed a commit
to schornakj/image_pipeline
that referenced
this pull request
Apr 26, 2022
Signed-off-by: Joe Schornak <joe.schornak@gmail.com>
clalancette
added a commit
that referenced
this pull request
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to fill the sparse areas with nearest neighbor depth values on upsampling operations in depth_image_proc/register . We make use of this function quite frequently. The PR does not alter the standard behavior.